google / google/ExoPlayer

Support VTT in Matroska

Open
#9,886 3 comments 0 reactions 1 assignee Claimed by @icbaker View on GitHub
enhancement low priority
Dominant language
Java
Stars
21.9k
Forks
6k
PR merge metrics
No merged PRs in 30d

Description

I'm looking into adding support for WebVTT embedded in Matroska (MKV).

I managed to get basic support in this patch: https://github.com/moneytoo/ExoPlayer/commit/09b07da83fb9cf6a0a6e511e7c0f6282c963e1da and it seems to be working with the sample provided to me in here: https://github.com/moneytoo/Player/issues/249

The patch still lacks support for styles as described in [Matroska specs](https://www.matroska.org/technical/subtitles.html#webvtt). I'm planning on looking into the styles as well, but I'm pretty busy lately so I'm wondering if I should send you PR with this basic support (is it worth an attempt?) or better wait and finish it all?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.