google / google/ExoPlayer

Add horizontal padding to subtitle background

Open
#9,813 1 comment 0 reactions 1 assignee Claimed by @icbaker View on GitHub
enhancement low priority
Dominant language
Java
Stars
21.9k
Forks
6k
PR merge metrics
No merged PRs in 30d

Description

Please consider adding horizontal padding of (text) subtitle background. (As also previously discussed here: https://github.com/google/ExoPlayer/issues/7516#issuecomment-646066696)

This is how it currently looks like:

The style preview in system captioning manager does include horizontal background padding:

After replacing `BackgroundColorSpan` in `SubtitlePainter` ([with something like this](https://medium.com/@tokudu/android-adding-padding-to-backgroundcolorspan-179ab4fae187)):

At least for me personally, this change significantly improves the (at a glance) readability of subtitles on both small and large screens.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.