google / google/ExoPlayer

TTML: Support tts:fontSize in Cell Size format

Open
#8,221 3 comments 0 reactions 1 assignee Claimed by @icbaker View on GitHub
enhancement
Dominant language
Java
Stars
21.9k
Forks
6k
PR merge metrics
No merged PRs in 30d

Description

### [REQUIRED] Use case description
ExoPlayer should support the specification of fontSize in cell dimension format. This format is specified in the corresponding W3C standard: https://www.w3.org/TR/2018/REC-ttml1-20181108/#style-attribute-fontSize

This format is used in the market. Currently it is not possible to decode these subtitles with ExoPlayer. The following log is output when a subtitle track is selected which uses this format:

`W/TtmlDecoder: Failed parsing fontSize value: 0.80c`

Currently ExoPlayer supports fontSize only in the following formats: px, em, %

### Proposed solution
Implement cell dimension format in TtmlDecoder.java

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.