google / google/ExoPlayer

TTML: Support tts:lineHeight setting

Open
#7,632 6 comments 0 reactions 1 assignee Claimed by @icbaker View on GitHub
enhancement
Dominant language
Java
Stars
21.9k
Forks
6k
PR merge metrics
No merged PRs in 30d

Description

### [REQUIRED] Use case description
Configurable Subtitles line spacing (extra, multiplier)
Business requirement is that lines needed to be further apart (based on provided line spacing). With ExoPlayer it can be achieved currently by applying lineSpacingMultiplier to Activity theme, but it seems to be not the best approach, as it introduces global change.

### Proposed solution
Currently line spacing logic is handled in SubtitlePainter - **lineSpacingExtra** and **lineSpacingMultiplier** is taken from Activity theme. Consider adding method to set expected values with SubtitleView, or add it to CaptionStyleCompat?

### Alternatives considered
n/a

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.