google / google/ExoPlayer

Make license renewal failure non-fatal until the end of the license duration

Open
#6,291 10 comments 0 reactions 1 assignee Claimed by @AquilesCanta View on GitHub
enhancement
Dominant language
Java
Stars
21.9k
Forks
6k
PR merge metrics
No merged PRs in 30d

Description

### [REQUIRED] Use case description
When the license is **really** expired we don't even pass the stream to ExoPlayer, we fire an error event instead. Now we also have to take this value into account, but it's a private constant (in DefaultDrmSession) so we can't. Hardcoding `60` (the current constant value) in our code seems like a bad idea because this value may change, at some point.

### Proposed solution
Move this value to the almighty C class (as public) - then we can read it.

### Alternatives considered
Hardcode this value in application code.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.