google / google/ExoPlayer

PlayerNotificationManager: support custom queue navigation

Open
#5,771 11 comments 0 reactions 1 assignee Claimed by @marcbaechinger View on GitHub
enhancement
Dominant language
Java
Stars
21.9k
Forks
6k
PR merge metrics
No merged PRs in 30d

Description

### [REQUIRED] Use case description

I have a custom queue navigator not based on a TimelineQueueNavigator. Inside a media session it works fine, however integration with the PlayerNotificationManager is more cumbersome than necessary. I tried to create a subclass from PlayerNotificationManager but the next() and previous() methods are private and most of the instance variables, so additional work is required. Copy and paste of the PlayerNotificationManager to create a custom version should not be easier than reusing the existing one. It does almost everything I want.

### Proposed solution

Enable delegation for queue actions to a custom QueueNavigator (same one as in the mediasession extension) so the onSkipToPrevious and onSkipToNext can be reused. In general is would be awesome to have less objects "private" and be able to supply custom versions easier.

### Alternatives considered
Complete custom management of notifications based on the media session.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.