google / google/ExoPlayer

ExoPlayer IMA extension for SSAI DASH Live stream.

Open
#10,912 10 comments 0 reactions 1 assignee Claimed by @marcbaechinger View on GitHub
enhancement
Dominant language
Java
Stars
21.9k
Forks
6k
PR merge metrics
No merged PRs in 30d

Description

According to https://developers.google.com/interactive-media-ads/docs/sdks/android/dai/exoplayer-extension I should be able to do this:

```
// Build an IMA SSAI media item to prepare the player with.
Uri ssaiLiveUri =
new ImaServerSideAdInsertionUriBuilder()
.setAssetKey(SAMPLE_ASSET_KEY)
.setFormat(CONTENT_TYPE_HLS) // Use CONTENT_TYPE_DASH for dash streams.
.build();
```

but with CONTENT_TYPE_DASH instead of CONTENT_TYPE_HLS

When we try the setup as above we get IllegalStateException and upon further investigation we can trace the source of this exception to ImaServerSideAdInsertionUriBuilder.createStreamRequest(...) call.

```
checkState(
streamRequest.getFormat() != StreamFormat.DASH
|| TextUtils.isEmpty(streamRequest.getAssetKey()),
"DASH live streams are not supported yet.");
```

We're using ExoPlayer version 2.18.2 and wondering when will you support DASH format for Live when using IMA SSAI?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.