google / google/ExoPlayer

Quit VSyncSampler thread after a timeout

Open
#10,765 2 comments 0 reactions 1 assignee Claimed by @tonihei View on GitHub
enhancement low priority
Dominant language
Java
Stars
21.9k
Forks
6k
PR merge metrics
No merged PRs in 30d

Description

### ExoPlayer Version

2.18.1

### Devices that reproduce the issue

Pixel 3 Android 10

### Devices that do not reproduce the issue

_No response_

### Reproducible in the demo app?

Yes

### Reproduction steps

New a player and play a video

then check the thread, the ExoPlayer:Frame thread is always running

choreographerOwnerThread = new HandlerThread("ExoPlayer:FrameReleaseChoreographer");

"ExoPlayer:Frame" sysTid=11687
#00 pc 00000000000d7af8 /apex/com.android.runtime/lib64/bionic/libc.so (__epoll_pwait+8) (BuildId: 505d14b082ba28d2c47b81224b56f21e)
#01 pc 0000000000019acc /system/lib64/libutils.so (android::Looper::pollInner(int)+184) (BuildId: 4e69b93bf70ed592f0029dbd1097529e)
#02 pc 00000000000199ac /system/lib64/libutils.so (android::Looper::pollOnce(int, int*, int*, void**)+112) (BuildId: 4e69b93bf70ed592f0029dbd1097529e)
#03 pc 0000000000119850 /system/lib64/libandroid_runtime.so (android::android_os_MessageQueue_nativePollOnce(_JNIEnv*, _jobject*, long, int)+44) (BuildId: ad5297ad1307688e551fe67c127cf1d9)
#04 pc 000000000021dbfc /system/framework/arm64/boot-framework.oat (art_jni_trampoline+140) (BuildId: 70b3fe6f83e0f7cd20f5a62e4d1aebc2d563f8d9)
#05 pc 00000000020197cc /memfd:jit-cache (deleted) (offset 0x2000000) (android.os.MessageQueue.next+204)
#06 pc 00000000021012b4 /memfd:jit-cache (deleted) (offset 0x2000000) (android.os.Looper.loop+660)
#07 pc 00000000001347e8 /apex/com.android.art/lib64/libart.so (art_quick_invoke_static_stub+568) (BuildId: 0148748321a155a1f417258148786a03)
#08 pc 00000000001a9a94 /apex/com.android.art/lib64/libart.so (art::ArtMethod::Invoke(art::Thread*, unsigned int*, unsigned int, art::JValue*, char const*)+228) (BuildId: 0148748321a155a1f417258148786a03)

### Expected result

The ExoPlayer:Frame thread should quit while the Exoplayer is release

### Actual result

the ExoPlayer:Frame thread is quit while the Exoplayer is release

### Media

Any video resource

### Bug Report

- [ ] You will email the zip file produced by `adb bugreport` to dev.exoplayer@gmail.com after filing this issue.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.