google-research / google-research/language

XSP data downloading script issues

Open
#194 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
1.8k
Forks
362
PR merge metrics
No merged PRs in 30d

Description

Hi, there are several issues with the `data_download.sh` script in the xsp subfolder.

1. From the download for scholar data onwards, the `wget` commands are not valid. They need to be edited to remove the ''blob'' in the url.
Example:
Original: `wget https://raw.githubusercontent.com/jkkummerfeld/text2sql-data/blob/master/data/scholar.json`
Edited: `wget https://raw.githubusercontent.com/jkkummerfeld/text2sql-data/master/data/scholar.json`

2. The `wget` commands for downloading all the schemas are due to the above issue also. Using the provided `wget`s will give us an invalid xml file with no schema information

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.