google-research / google-research/big_vision

Text lowering issue

Open
#79 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
3.5k
Forks
227
PR merge metrics
No merged PRs in 30d

Description

I found an issue here https://github.com/google-research/big_vision/blob/main/big_vision/pp/ops_text.py#L165
When lowering UTF-8 non-latin text `encoding ='utf-8'` should be used as mentioned here https://www.tensorflow.org/api_docs/python/tf/strings/lower .

This at least can influence at i18n model.
But due to models already trained, i'm not sure if this issue should be fixed.

Contributor guide

Open the contributing guide

Research direction

Start at big_vision/pp/ops_text.py around line 165 and compare the current lowering call with the TensorFlow tf.strings.lower documentation linked in the issue. Verify the behavior for UTF-8 non-Latin text and consider the stated compatibility concern for already-trained models; done means the intended behavior and whether a fix is appropriate are established.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, tensorflow
Domain
internationalization, machine-learning
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.