google-pay / google-pay/flutter-plugin

Come up with a better name for `childOnError`: the property holding the UI to show when the button is not available

Open
#8 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Dart
Stars
176
Forks
147
PR merge metrics
No merged PRs in 30d

Description

The brand guidelines of the button encourage developers to remove the button altogether if the paying with the provider in question is not supported or unavailable. The property childOnError offers implementers a chance to decide what UI to show in case the button can't be displayed.

Come up with a more intuitive name that conveys not only error, but also successful, yet unavailable responses.
Ideas:

  • replacement
  • childIfUnavailable

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the childOnError property and all references in the Flutter plugin. Review how the property represents unavailable payment-button states, then propose a name that covers both error and successful-but-unavailable responses; done means agreeing on and applying the new name consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
dart
Domain
mobile
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.