google-gemini / google-gemini/gemini-cli

# docs(hooks): document missing HookDecision values (`ask`, `approve`)

Open Beginner friendly
#28,977 0 comments 0 reactions 0 assignees View on GitHub
area/documentation kind/bug priority/p3 status/bot-triaged
Dominant language
TypeScript
Stars
107k
Forks
14.6k
Avg merge
2d 3h
Merged PRs (30d)
45

Description

### What happened?

The Hooks reference documentation in `docs/hooks/reference.md` does not list all supported values for the `decision` field.

The documentation currently states:

```markdown
| `decision` | `string` | `"allow"` or `"deny"` (alias `"block"`). Specific impact depends on the event. |

### What did you expect to happen?

### What did you expect to happen?

```markdown
The Hooks reference should document all supported `HookDecision` values so that the documentation accurately reflects the TypeScript implementation:

- `ask`
- `approve`
- `block`
- `allow`
- `deny`

### Client information

- **Platform:** Windows
- **Component:** Gemini CLI Hooks documentation
- **Affected file:** `docs/hooks/reference.md`

The `/about` output is not applicable because this is a documentation-only issue.

### Login information

Not applicable. This issue does not depend on the authentication method.

### Anything else we need to know?

Relevant source locations:

- `docs/hooks/reference.md` around line 72
- `packages/core/src/hooks/types.ts` around lines 130–136

The documentation should be updated to remain consistent with the `HookDecision` type definition.

Contributor guide

Open the contributing guide

Research direction

Open docs/hooks/reference.md around line 72 and compare the decision field with packages/core/src/hooks/types.ts around lines 130–136. Update the reference to list ask, approve, block, allow, and deny, then verify the documentation matches the HookDecision definition.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
documentation
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
92/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.