google-deepmind / google-deepmind/xmanager

Make URL prefix in `_get_image_name`-function more flexible

Open
#50 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
921
Forks
69
Avg merge
1d 1h
Merged PRs (30d)
1

Description

Currently, [`_get_image_name`](https://github.com/google-deepmind/xmanager/blob/7a9cfd0b1edf777cd4b10b9f81ab3a8a8bbdc9ec/xmanager/cloud/build_image.py#L171-L175) hardcodes the `gcr.io/` prefix. It would be nice to allow custom prefixes to enable better control over the location, for example via `pkg.dev` repositories in Artifact Registry (which has since replaced the deprecated [Container Registry](https://cloud.google.com/artifact-registry/docs/transition/gcr-repositories)).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.