google-deepmind / google-deepmind/tree

0.1.8 building from source silently fails, missing abseil-cpp dependency

Open
#103 8 comments 1 reaction 0 assignees View on GitHub
Dominant language
Python
Stars
1k
Forks
73
PR merge metrics
No merged PRs in 30d

Description

Building from the sdist on PyPI or from Github silently succeeds and then fails with missing symbols when you import tree:
```
_tree.cpython-38-x86_64-linux-gnu.so: undefined symbol: _ZN4absl12lts_2021032420raw_logging_internal6RawLogENS0_11LogSeverityEPKciS4_z
```

The abseil-cpp dependency is not fetched and CMake did not request to find this dependency : https://github.com/deepmind/tree/blob/378f432e2a63cf1260f26f10fc4ccebd102a5b8a/tree/CMakeLists.txt#L71

To reproduce:
```
pip install dm-tree==0.1.8
python -c 'import tree'
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.