google-deepmind / google-deepmind/torax

Check that required fields are present in IMAS geometry loader

Open
#2,409 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
721
Forks
145
Avg merge
2d 14h
Merged PRs (30d)
49

Description

We should check required fields are present and raise an error if they are not.
Currently, if e.g. gm7 is not present in the equilibrium IDS, the config builder will fail with a shape error that is hard to pin down.

Currently checking of many fields is done lazily, but many fields have also been missed. I wonder whether it would be better to do eager checking at the start?

Contributor guide

Open the contributing guide

Research direction

Start at the IMAS geometry loader and inspect how required fields are currently checked lazily. Reproduce the missing-gm7 case in the equilibrium IDS, then identify the required fields and ensure absent fields produce a clear error before the config builder reaches a shape error.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.