google-deepmind / google-deepmind/reverb

Feature request: timeout argument for `client.sample`

Open
#18 15 comments 0 reactions 1 assignee Claimed by @ebrevdo View on GitHub
enhancement
Dominant language
C++
Stars
793
Forks
113
PR merge metrics
No merged PRs in 30d

Description

Similarly to #4, it would be useful to be able to back out of sampling without needing to wrap things in a thread or use an executor. I agree that in many cases, you'd want to sample asynchronously to maximize throughput, but there are cases where the predictability and simplicity are preferable even if comes at the expense of efficiency (e.g., in research). A timeout argument would simplify the synchronous setting without sacrificing safeguards from indefinite waiting.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.