google-deepmind / google-deepmind/pysc2
Raw Unit Y-Axis Assumes Square
Open
- Dominant language
- Python
- Stars
- 8.3k
- Forks
- 1.2k
- PR merge metrics
- No merged PRs in 30d
Description
In Features.py:
world_tl_to_feature_minimap = transform.Linear(
scale=raw_resolution / map_size.max_dim() if raw_resolution else None)
This only works correctly if the map is a square. Otherwise the dimension that is smaller than map_size.max_dim() gets improperly scaled down. The correct solution would be to scale each dimension of raw resolution by the commensurate max length of each map dimension.
-Ian
Contributor guide
Assessment
This issue has not been assessed yet.