google-deepmind / google-deepmind/optax

Minor suggestions for make_perturbed_fun

Open
#1,342 4 comments 0 reactions 0 assignees View on GitHub
type:feature
Dominant language
Python
Stars
2.3k
Forks
369
Avg merge
10h 15m
Merged PRs (30d)
7

Description

I have some minor suggestions for [make_perturbed_fun](https://optax.readthedocs.io/en/latest/api/perturbations.html#make-perturbed-function):

- Rename `sigma` to `scale`, which is more generic and self-explanatory. Note that [Berthet et al.](https://arxiv.org/abs/2002.08676) sometimes uses $\varepsilon$ for this, instead of $\sigma$.
- Change the default value for `num_samples` from 1000 (a large arbitrary value) to 1. This is a less arbitrary value, and more common in stochastic optimization (where the objective function is itself stochastic).

If one or both of these are desirable, I can create a PR. Otherwise, this issue can be closed.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.