google-deepmind / google-deepmind/gemma

Issue with unit tests on NVIdia A100 (GPU)

Open
#33 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
5.7k
Forks
1k
Avg merge
10h 33m
Merged PRs (30d)
2

Description

Hi everyone.

I see the issue when run unit tests on NVidia A100 (GPU). Here is the [link](https://github.com/NVIDIA/JAX-Toolbox/actions/runs/9099672951/job/25013673011?pr=590#step:7:593) for more details.

Briefly:
```
=========================== short test summary info ============================
FAILED opt/gemma/gemma/layers_test.py::EinsumTest::test_rmsnorm0 - AssertionE...
FAILED opt/gemma/gemma/modules_test.py::FeedForwardTest::test_ffw0 - Assertio...
FAILED opt/gemma/gemma/positional_embeddings_test.py::PositionalEmbeddingsTest::test_adds_positional_embeddings0
FAILED opt/gemma/gemma/sampler_test.py::SamplerTest::test_forward_equivalence
================== 4 failed, 12 passed, 2 warnings in 26.55s ===================
```

The first 3 is similar to issues on V100 (#32), but the last one:
4. test_forward_equivalence [link](https://github.com/NVIDIA/JAX-Toolbox/actions/runs/9099672951/job/25013673011?pr=590#step:7:574). Can you relax the tolerance when run on GPUs?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.