google-deepmind / google-deepmind/distrax

Confusing distrax.Chain syntax

Open
#324 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
651
Forks
48
Avg merge
21h 4m
Merged PRs (30d)
3

Description

The syntax for constructing a chain is very confusing and inconsistent with most other libraries which build chains of functions.

For example:

```
bijector = distrax.Chain([
distrax.ScalarAffine(shift = shift, scale = scale),
distrax.Tanh()
])
```

first applies Tanh and then applies ScalarAffine. Intuitively it should be the other way around.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.