google-deepmind / google-deepmind/deepmind-research
Missing flag definitions
Open
- Dominant language
- Jupyter Notebook
- Stars
- 15.2k
- Forks
- 2.9k
- PR merge metrics
- No merged PRs in 30d
Description
The shell script run_adult_pscf.sh passes the flags: dataset_dir and numstep but they are not defined in the following file.
Ref to line in script.
https://github.com/deepmind/deepmind-research/blob/cb555c241b20c661a3e46e5d1eb722a0a8b0e8f4/counterfactual_fairness/run_adult_pscf.sh#L36
https://github.com/deepmind/deepmind-research/blob/cb555c241b20c661a3e46e5d1eb722a0a8b0e8f4/counterfactual_fairness/adult_pscf.py#L41
The solution is to define the flags as follows. The default values I have chosen are arbitrary.
flags.DEFINE_string ("dataset_dir", "", "Sets the dataset directory")
flags.DEFINE_string ("num_steps", "10", "Sets the number of steps")
Contributor guide
Assessment
This issue has not been assessed yet.