google-deepmind / google-deepmind/chex

Use of deprecated type hints - PEP 585

Open
#361 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
957
Forks
74
Avg merge
21h 10m
Merged PRs (30d)
1

Description

Hello,

I am a frequent user of your library, but I also like to enforce good type hints, using type checkers like `beartype`.

However, when using types from your library, it appears that some of them use deprecated type hints from the built-in `typing` module, like `typing.Iterator` that has been moved to `collections.abc.Iterator`.

While this is not an issue at the moment (except that `beartype` complains about it, see https://beartype.readthedocs.io/en/latest/api_roar/#pep-585-deprecations), this will eventually become one when Python 3.14 will come out (in ~ 1 year I guess).

Could you consider updating the type hint to make your library future-compatible (at least to some extents)? Of course, I can help with this and make a PR.

Thanks for your work!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.