google-deepmind / google-deepmind/alphageometry

Is add_eq2 correct?

Open
#68 3 comments 1 reaction 0 assignees View on GitHub
Dominant language
Python
Stars
4.9k
Forks
572
PR merge metrics
No merged PRs in 30d

Description

Should it be self.add_expr([(a, n), (b, -m)])?
------------------------------
def add_eq2(
self, a: str, b: str, m: float, n: float, dep: pr.Dependency
) -> None:
# a/b = m/n
if not self.add_expr([(a, m), (b, -n)]):
return []
self.register2(a, b, m, n, dep)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.