google-deepmind / google-deepmind/alphafold

Pushd and popd commands still haven't been removed from download scripts on the main branch.

Open
#557 0 comments 0 reactions 0 assignees View on GitHub
setup
Dominant language
Python
Stars
14.9k
Forks
2.9k
PR merge metrics
No merged PRs in 30d

Description

Hello,

When I tried to run download_all_data.sh, I kept running into a gzip error where it couldn't find the file. The path and filename seemed right, but when digging through the issues and scripts, I found that `download_mgnify.sh, download_small_bfd.sh, download_uniprot.sh, and download_uniref90.sh` on the main branch still had the extra pushd and popd pointed out in #305 and #459.

`pushd "${ROOT_DIR}" `
`gunzip "${ROOT_DIR}/${BASENAME}" `
`popd`

where `ROOT_DIR="${DOWNLOAD_DIR}/(`name of database being downloaded`)"`

To my understanding, this code is entering the root dir, and then unzipping the file with root_dir in the path again. If the user-specified DOWNLOAD_DIR isn't the full path, then this will cause an error. If it is the full path, then pushd and popd are useless.

What would be the process for getting this fixed?

Thank you in advance!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.