google-deepmind / google-deepmind/acme
Error importing `matplotlib`
Open
- Dominant language
- Python
- Stars
- 4.1k
- Forks
- 553
- PR merge metrics
- No merged PRs in 30d
Description
[`video.py`](https://github.com/deepmind/acme/blob/d1e69c92000079b118b868ce9303ee6d39c4a0b6/acme/wrappers/video.py#L29) imports `matplotlib` which is not an explicit dependency listed in `setup.py`.
Happy to contribute a fix but I do not know which solution do you guys want:
1. Explicitly list the dependency in `setup.py` - simplest
2. Do not automatically import `VideoWrapper` from `video.py` in the wrapper module - this could be argued better if you want a minimal acme dependencies?
Looking forward to hearing from you guys.
Contributor guide
Assessment
This issue has not been assessed yet.