gomorizsolt / gomorizsolt/react-theme-toggle-button

Add option to invert logic of the button icons

Open
#5 2 comments 0 reactions 0 assignees View on GitHub
good first issue
Dominant language
JavaScript
Stars
0
Forks
1
PR merge metrics
No merged PRs in 30d

Description

I'd like to have the sun displayed if the light theme is active, so the sun will show to indicate that it's the light theme and if the dark theme is active I'd like to show the moon.

The current implementation is showing what the button will do but the described behaviour feels more natural IMO. Both could be added so it can be changed with a prop.

To make it more clear, I've created a [sandbox](https://codesandbox.io/s/react-theme-toggle-button-olr5g) with the modified button code.

If you like I could create a PR for this.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.