goldbergyoni / goldbergyoni/javascript-testing-best-practices

Section 1.1 example code should check for true, not false

Open
#26 2 comments 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
24.6k
Forks
2.1k
PR merge metrics
No merged PRs in 30d

Description

The second example in section 1.1 says:

`expect(result.approved).to.be.false;`

It should be:

`expect(result.approved).to.be.true;`

(I'm guessing you made it false so you could simulate the error output in the next picture.)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.