goldbergyoni / goldbergyoni/javascript-testing-best-practices

edupro-social-links-widget-1 needs fix

Open
#204 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
24.6k
Forks
2.1k
PR merge metrics
No merged PRs in 30d

Description

# Description
At this moment content of `edupro-social-links-widget-1` works incorrect. See screenshots and details below.
First issue - there is an icon of Google+ (inactive platform since ~2019). Second issue - icons/links are not working correct now.

# Repro steps
1. Go to: https://testjavascript.com/
2. Scroll down, take a look at `edupro-social-links-widget-1` elements. Click on the icons
3. See the issue

# Screenshots
Google+ icon (inactive platform)
![image](https://user-images.githubusercontent.com/18367606/166156748-30887dbc-6a17-4ec5-9dbe-8c65be4d1a29.png)

Link for fix - FB example
![image](https://user-images.githubusercontent.com/18367606/166156872-fd5d9b31-f7f1-4f95-b50c-e667bf4366fe.png)

Link for fix - Twitter example
![image](https://user-images.githubusercontent.com/18367606/166156912-7d5aa3ce-ef25-4b4a-85af-14fe2ea0041f.png)

# Additional info
After clicking, it redirects to the website: https://testjavascript.com/

PS. Small suggestion from my side - I think it would be great to open the site (correct site) in new tab (`target="_blank"`) instead of the same tab.

Best wishes,

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.