golang / golang/groupcache

http pool basePath getter and/or setter?

Open
#22 8 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Go
Stars
13.3k
Forks
1.4k
PR merge metrics
No merged PRs in 30d

Description

I'm building a server that uses groupcache, and I would like to be able to conveniently wrap the http pool's handler inside a mux (specifically to add a monitoring status call on the server).

I simply thought of adding a handler func that forwards everything under /_groupcache/ to groupcache's handler. But this will fail if ever the hard coded base path will change.

So I thought of adding at least a getter, if not a setter for the base path. I understand the consistency problem with adding a setter. Will a pull request for GetBasePath() and/or SetBasePath() be accepted?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.