golang / golang/groupcache

may you add default replicas ?

Open
#156 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
13.3k
Forks
1.4k
PR merge metrics
No merged PRs in 30d

Description

1.add default replicas
groupcache/consistenthash.go: line 34.
replicas must has a default value. if replicas <=0, then it will do nothing when call `func (m *Map) Add(keys ...string)`

and i suggest the default replicas value is 23

2.add sync.Mutex. when call Add and Get,we can lock the kes and hashMap

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.