gojuno / gojuno/minimock

can't generate mocks after updating to v3.4.6

Open
#147 1 comment 9 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
752
Forks
49
PR merge metrics
No merged PRs in 30d

Description

//go:generate minimock -i gitlab.~~hidden.com~~/platform/realtime-config-go.Client -o realtime_config_client.go -n ClientMock -p mocks
fails with
`minimock: failed to generate mock: template: header:14:147: executing "header" at <"MockName">: wrong type for value; expected language.Tag; got string`

I think that the reason is [this change](https://github.com/gojuno/minimock/commit/2cee44ae03d04bb3b90dca3248d2433fb65bfdb5#diff-e264fc81209f228f91f0ab1a2db86a64169090735dacda0eb96679cf318f8e8eL37-R36)

old (strings):
func Title(s [string](https://pkg.go.dev/builtin#string)) [string](https://pkg.go.dev/builtin#string)

new (cases):
func Title(t [language](https://pkg.go.dev/golang.org/x/text@v0.28.0/language).[Tag](https://pkg.go.dev/golang.org/x/text@v0.28.0/language#Tag), opts ...[Option](https://pkg.go.dev/golang.org/x/text/cases#Option)) [Caser](https://pkg.go.dev/golang.org/x/text/cases#Caser)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.