goharbor / goharbor/harbor-cli

CLI continues execution after log.Errorf() instead of returning error

Open
#655 4 comments 0 reactions 0 assignees View on GitHub
duplicate
Dominant language
Go
Stars
163
Forks
211
Avg merge
1m
Merged PRs (30d)
1

Description

In multiple Harbor CLI commands, when an error occurs it is logged using log.Errorf() but the function does not return the error. Execution continues after the error, causing variables like projectName, repoName, or reference to be empty or invalid.

Because of this, the command does not fail immediately and instead proceeds with incorrect state, leading to silent failures and confusing downstream behavior. The CLI appears to run successfully even though a critical error has already occurred.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.