goftpd / goftpd/goftpd

ACL - Add CheckIP test(s)

Open
#7 0 comments 0 reactions 0 assignees View on GitHub
good first issue help wanted
Dominant language
Go
Stars
11
Forks
2
PR merge metrics
No merged PRs in 30d

Description

Perfect candidate for a test using testcases/table driven (i.e. https://github.com/goftpd/goftpd/blob/master/acl/permissions_test.go#L21)

```
type test struct {
user string
raddr string
mask string
}
```

The test would have to make an ident listener on the laddr and respond to ident requests (can borrow an indetd server from here: https://git.sr.ht/~emersion/soju/tree/28cf1147e83c/ident.go#L47). Alternative would be to supply an ident check to the Authenticator as part of initialisation so that we don't have to do network integration tests and would simplify these tests significantly.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.