godotengine / godotengine/godot

Double-click to rename in scene tree sometimes renames without double-click

Open
#97,702 2 comments 0 reactions 0 assignees View on GitHub
bug topic:editor topic:input
Dominant language
C++
Stars
117k
Forks
26.8k
PR merge metrics
PR metrics pending

Description

### Tested versions

Reproducible in 4.3-stable

### System information

Godot v4.3.stable - Pop!_OS 22.04 LTS - X11 - Vulkan (Forward+) - dedicated AMD Radeon RX 580 Series (RADV POLARIS10) - AMD Ryzen 7 7700X 8-Core Processor (16 Threads)

### Issue description

When selecting multiple items in the scene tree, there are two methods I'm aware of:

- click, shift+click, and
- hold ctrl, click click click
(also the combination of both, but let's not get ahead of ourselves)

The latter puts the last clicked node in focus, while the former puts the highest node in focus.

Double clicking a node opens the rename-popup(?). The way this appears to be implemented is by just checking whether the clicked node was already in focus,
(with some safeguards that trip when another part of the UI is clicked or the cursor is moved over the 2D/3D Editor.)
and not whether a double-click action was performed.

This bug causes clicking the focused node in a multi-selection to open the rename-popup, even when it was single clicked and not double clicked.

Put differently: Shift+click select then click behaves differently for the highest item in the scene tree selection vs others.

### Steps to reproduce

Method A:

1. have some nodes in your scene.
2. click one in the scene tree
3. wait a while, move your mouse around, shift+tab into another application, shift+tab back
4. click the node again

Method B:
1. have some nodes in your scene
2. click something in the 2D/3D Editor
3. shift+click a lower node in the scene tree
4. click the node from step 2 in the scene tree

### Minimal reproduction project (MRP)

N/A

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.