godotengine / godotengine/godot
Pop when enabling audio filter, such as LowPassFilter
- Dominant language
- C++
- Stars
- 117k
- Forks
- 26.8k
- PR merge metrics
- PR metrics pending
Description
### Tested versions
4.0 - 4.3 rc2
### System information
Windows 10, Vulkan forward +, Nvidia 3070
### Issue description
When enabling filters on a bus, there can be a pop or crack, depending on the wave form when the filter is enabled. For example, I enable a low pass filter when the player enters the water, and sometimes there's a very audible click or pop.
### Steps to reproduce
1. Add a LowPassFilter to the Master bus.
2. Toggle it on and and off with AudioServer.set_bus_effect_enabled()
3. Note that sometimes there's a pretty glaring pop.
### Minimal reproduction project (MRP)
[test_filter_pop.zip](https://github.com/user-attachments/files/16554589/test_filter_pop.zip)
Contributor guide
Research direction
Start with the attached test_filter_pop.zip reproduction project and reproduce the issue by toggling the effect through AudioServer.set_bus_effect_enabled(). Trace the audio filter enable path and verify that enabling or disabling a LowPassFilter no longer produces an audible pop across the provided reproduction steps.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- audio-video-rtc
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100