godotengine / godotengine/godot

Property Editor/Expand All keyboard shortcut doesn't work anymore

Open
#93,009 3 comments 0 reactions 0 assignees View on GitHub
discussion needs testing topic:editor topic:input
Dominant language
C++
Stars
117k
Forks
26.8k
PR merge metrics
PR metrics pending

Description

### Tested versions

- Reproducible in 4.2.1 and 4.2.2
- Cannot be reproduced in 3.5.3

### System information

Windows 10

### Issue description

If you set the keyboard shortcut in Editor Settings > Shortcuts > Property Editor > Expand All, then try to use that keyboard shortcut, it does not expand all of the property dropdowns for a given node.

If you instead click on a node, go over to the Property Editor, and click the Tool option in the top right, then Expand All, it works. So the Action called Expand All is functional - it's just that the keyboard shortcut doesn't get through.

I've tried with multiple keyboard shortcuts and I've set the same shortcuts for other actions and had them trigger without any issue. It appears (from my user-based testing) to be specific to this Expand All shortcut.

I also tried clearing my old app data/editor settings for godot and re-trying but to no avail.

### Steps to reproduce

- Open a project in 4.2.2 / 4.2.1
- Click on Editor > Editor Settings > Shortcuts and search for the word 'expand'
- Set a shortcut for the Expand All command under Property Editor
![image](https://github.com/godotengine/godot/assets/100398434/39f33a48-a968-4036-be86-91526fe60f94)

- Close out of the settings and select a node
- Hit the shortcut and notice that the node properties on the right do not expand
- To confirm that expansion works, click on the screwdriver/spanner icon in the top-right of the Property Editor and hit Expand All
- Note that it works - and note that it shows that your shortcut is set as well (despite it not working)
![image](https://github.com/godotengine/godot/assets/100398434/65c26ca7-4da8-4e68-a4d2-d88f0fab2d8a)

### Minimal reproduction project (MRP)

N/A

Contributor guide

Open the contributing guide

Research direction

Reproduce this in Godot 4.2.1 or 4.2.2 through Editor Settings > Shortcuts > Property Editor > Expand All, then compare the keyboard action with the working Property Editor tool-menu action. Trace the Property Editor shortcut and Expand All entry points; done means the configured shortcut expands all properties for the selected node just like the menu command.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.