godotengine / godotengine/godot

When importing image as Font Data resource, out of bounds row/column values cause crash upon clicking reimport

Open
#89,557 0 comments 0 reactions 0 assignees View on GitHub
bug crash needs testing topic:editor topic:import
Dominant language
C++
Stars
117k
Forks
26.8k
PR merge metrics
PR metrics pending

Description

### Tested versions

v4.2.1.stable.official [b09f793f5]

### System information

Godot v4.2.1.stable - Windows 10.0.22621 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3080 (NVIDIA; 31.0.15.3770) - 12th Gen Intel(R) Core(TM) i9-12900 (24 Threads)

### Issue description

If you set the rows/columns to 0 when importing a font data image, it crashes the editor. The field should be sanitized to only accept values >=1

### Steps to reproduce

![image](https://github.com/godotengine/godot/assets/89282845/1697dacd-a6fa-47c1-9879-80e8f8211a6c)
click 'reimport'

### Minimal reproduction project (MRP)

N/A

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the crash in the Godot editor using a font data image with rows or columns set to 0, then locate the import settings and validation path involved in reimporting it. Done means values below 1 are rejected or sanitized and clicking Reimport no longer crashes the editor.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.