godotengine / godotengine/godot

AudioStreamPlaybackPolyphonic doesn't emit `finished` signal for each AudioStream neither allow get the reference from ID

Open
#88,941 6 comments 2 reactions 0 assignees View on GitHub
enhancement topic:animation topic:audio
Dominant language
C++
Stars
117k
Forks
26.8k
PR merge metrics
PR metrics pending

Description

### Tested versions

Godot 4.2.1

### System information

Godot v4.2.1.stable - macOS 13.4.1 - Vulkan (Forward+) - integrated Apple M1 - Apple M1 (8 Threads)

### Issue description

`AudioStreamPlayer`s don't emit the `finished` signal after playing a stream from an Audio Playback track.

### Steps to reproduce

Add an animation with an Audio Playback track. Connect the `AudioStreamPlayer`'s `finished` signal to a method in a script, and do a `print()`

### Minimal reproduction project (MRP)

N/A

Contributor guide

Open the contributing guide

Research direction

Start with the AudioStreamPlaybackPolyphonic implementation and the animation Audio Playback track described in the reproduction steps. Trace how each played AudioStream is tracked and how the AudioStreamPlayer finished signal is emitted; done means each stream emits finished and its reference can be retrieved from its ID.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
audio-video-rtc
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.