godotengine / godotengine/godot

Make Unique (recursive) fails due to Condition "states.has(p_name)" is true

Open
#87,766 2 comments 0 reactions 0 assignees View on GitHub
bug regression topic:animation topic:editor
Dominant language
C++
Stars
117k
Forks
26.8k
PR merge metrics
PR metrics pending

Description

### Tested versions

Reproducable in: 4.2.1.mono and 4.3.dev2.mono

### System information

Godot v4.3.dev2.mono - Windows 10.0.22621 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4090 (NVIDIA; 31.0.15.3742) - 13th Gen Intel(R) Core(TM) i9-13900K (32 Threads)

### Issue description

Make Unique (recursive) on an AnimationRootNode fails on every subresource with Condition "states.has(p_name)" is true.

### Steps to reproduce

Create an AnimationTree with any root node.
Add any amount of AnimationRootNode to it.
Right Click the Tree Root in the Editor and click Make Unique (recursive).
![image](https://github.com/godotengine/godot/assets/5581583/8178bf6f-a6a7-4077-af14-097409bc8b2e)

### Minimal reproduction project (MRP)

[Test.zip](https://github.com/godotengine/godot/files/14105997/Test.zip)

Contributor guide

Open the contributing guide

Research direction

Start with the AnimationTree editor's Tree Root and the Make Unique (recursive) action, using the attached Test.zip reproduction project to reproduce the failure on AnimationRootNode subresources. Done means the recursive operation completes without the "states.has(p_name)" condition error and makes the affected subresources unique.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.