godotengine / godotengine/godot
Default fonts alias switch on Windows
- Dominant language
- C++
- Stars
- 117k
- Forks
- 26.8k
- PR merge metrics
- PR metrics pending
Description
### Tested versions
I think the bug was always present.
### System information
Windows
### Issue description
The standard Windows fonts for alias "cursive" (Comic Sans MS) and "fantasy" (Gabriola) are mistakenly switched. Gabriola is cursive and matches other cursive fonts, while Comic Sans is not.

I found the issue in the docs, made docs issue https://github.com/godotengine/godot-docs/issues/11073, and AThousandShips found it in the engine and suggested to make a report here.
https://github.com/godotengine/godot/blob/efb40c1524e54f2cf52f213e248bd0a7b790975a/platform/windows/os_windows.cpp#L1727-L1741

Seems like an easy fix but I'm a noob, especially with using github properly
### Steps to reproduce
Haven't used it.
### Minimal reproduction project (MRP)
I don't think a sample project is needed
Contributor guide
Research direction
Open platform/windows/os_windows.cpp around lines 1727-1741 and inspect the Windows font alias mapping for "cursive" and "fantasy". Confirm the aliases match the standard Windows fonts, then verify the corrected behavior on Windows; the separate documentation issue is linked in the report.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop, operating-systems
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 52/100