godotengine / godotengine/godot

string exceeds 65535 bytes in length error when building cloned repo

Open
#101,150 5 comments 0 reactions 0 assignees View on GitHub
bug needs testing platform:windows topic:buildsystem
Dominant language
C++
Stars
117k
Forks
26.8k
PR merge metrics
PR metrics pending

Description

### Tested versions

Happens with the latest changes in the repo cloned to my hard drive.

### System information

Windows 11

### Issue description

Windows 11.
When I run the command `scons platform=windows` I get the following error multiple times.
```
.\servers/rendering/renderer_rd/shaders/effects/fsr_upscale.glsl.gen.h(13): fatal error C1091: compiler limit: string exceeds 65535 bytes in length
scons: *** [platform\windows\os_windows.windows.editor.x86_64.obj] Error 2
```
Based on the error itself, it sounds like it's an error in the code and not something on my end? Tried troubleshooting in the godot forums and google searching, and all I could find is it's likely an issue with the code in the repo.(But surely it would be happening to more people than just me?)

The full error list is as follows
```
.\servers/rendering/renderer_rd/shaders/effects/fsr_upscale.glsl.gen.h(13): fatal error C1091: compiler limit: string exceeds 65535 bytes in length
.\servers/rendering/renderer_rd/shaders/effects/fsr_upscale.glsl.gen.h(13): fatal error C1091: compiler limit: string exceeds 65535 bytes in length
scons: *** [platform\windows\native_menu_windows.windows.editor.arm64.obj] Error 2
scons: *** [platform\windows\display_server_windows.windows.editor.arm64.obj] Error 2
.\servers/rendering/renderer_rd/shaders/effects/fsr_upscale.glsl.gen.h(13): fatal error C1091: compiler limit: string exceeds 65535 bytes in length
scons: *** [platform\windows\os_windows.windows.editor.arm64.obj] Error 2
scons: building terminated because of errors.
```

### Steps to reproduce

CD into the repo directory.
run the command `scons platform=windows`
Wait for it to process a number of things and then give out the errors

### Minimal reproduction project (MRP)

N/A

Contributor guide

Open the contributing guide

Research direction

Reproduce the Windows build with `scons platform=windows` and inspect `servers/rendering/renderer_rd/shaders/effects/fsr_upscale.glsl.gen.h`, especially the reported line 13. Compare the generated shader header with the MSVC compiler limit described in the error. Done means the Windows build no longer fails with C1091 for the affected targets.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.