godotengine / godotengine/godot-visual-script

Make sure the Visual Script submenus/popups don't open in separate window

Open
#28 3 comments 1 reaction 0 assignees View on GitHub
bug
Dominant language
C++
Stars
131
Forks
25
PR merge metrics
No merged PRs in 30d

Description

**Godot version:**
`master`

**OS/device including version:**
all

**Issue description:**
Visual Script submenus/popups open in separate window

![image](https://user-images.githubusercontent.com/19930870/78295006-024ec300-7549-11ea-896c-8c4738bb9d4f.png)

![image](https://user-images.githubusercontent.com/19930870/78295092-2a3e2680-7549-11ea-8e29-4b8158c92947.png)

**Steps to reproduce:**
one of the many, Right click on the visual script.

**Cause:**
(I believe it's because) We use AcceptDialogs by default for just about everything in VisualScript. Except some edge cases like right clicking on variables opens a PopupMenu.

**ASIDE**

Part of godotengine/godot-visual-script#37

cc: @fire am I doing something wrong? Cause otherwise visual script it quite broken at the moment.

I will check to make sure if it's not my mistake anywhere, if not I will start on a fix for it in the morning.

Also not sure but there also seem to be some bugs with the Dialogs that open in new window. Should I actually create bug reports for all of them. Or just submit separate PRs while fixing the visual script stuff?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.