godotengine / godotengine/godot-git-plugin

Add a hint to the Comment TextEdit to denote that filling it is required

Open
#91 4 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C++
Stars
954
Forks
98
PR merge metrics
No merged PRs in 30d

Description

Hello!

This likely falls more into newbie-assistance getting used to the workflow of the plugin.

Once first opened, and once items are selected to be staged, the 'Commit Changes' button is disabled until a commit comment is added.

Could I suggest the border be highlighted once there are files waiting? I understand 'placeholder' for textfields doesn't exist.

Might I suggest having a label above the field saying "[Required] Commit Comment". Once a commit is made, it doesn't disable the button, and looks like it is quite happy to commit with empty comments. This might be intentional?

I'd also like to suggest if you disabled the button, you could put there the confirmation "committed x files" text and remove the label.

There is possibly some hover-text opportunities too.

Thanks for making the plugin available :)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.