godotengine / godotengine/godot-docs

3.x to 4.x Conversion Documentation Missing Manual Conversions

Open
#9,850 0 comments 0 reactions 0 assignees View on GitHub
area:manual bug
Dominant language
reStructuredText
Stars
5.7k
Forks
3.8k
Avg merge
1d 20h
Merged PRs (30d)
25

Description

**Your Godot version:**
4.2.2
**Issue description:**
The conversion page states:
> The list below contains all renames that must be performed manually using the script editor.

But the list was missing some manual renames listed in the [renames map](https://github.com/godotengine/godot/blob/master/editor/renames_map_3_to_4.cpp). I have addressed most of them in #9849.

What follows is the list of ones that I am unsure about. There will also be an engine bug because I have found many renames that are not listed either here or there, so it's unclear if they would be manual or could be handled automatically,

### Listed as manual in renames_map, but not in documentation
#### Theme
(These are ones I couldn't find - but are listed as manual renames)
- { "bg", SceneStringName(panel) }, // Theme
- {"theme_override_styles/bg", "theme_override_styles/bg" }, // GraphEdit
- { "theme_override_styles/bg", "theme_override_styles/panel" }, // ScrollContainer
- { "theme_override_styles/bg", "theme_override_styles/background" }, // ProgressBar
- { "theme_override_styles/fg", "theme_override_styles/fill" }, // ProgressBar

### Listed as manual in documentation, but not in renames_map
(I assume that the renames_map is authoritative here and these aren't manual anymore)
- AcceptDialog `set_autowrap()` -> `set_autowrap_mode()`
- GridMap's `world_to_map()` -> `local_to_map()`
- TileMap's `world_to_map` -> `local_to_map`
- SceneTree's `change_scene()` -> `change_scene_to_file()'
- MultiPlayerAPI's `new_network_connections` -> `refuse_new_connections`
- Color names are listed in automatic rename

### Not mentioned in renames at all, but claimed as manual in documentation
(I'm not sure which is supposed to be authoritative here - these would need to be investigated.)
- File -> FileAccess
- OS singleton -> DisplayServer
- OS singleton -> Time singleton
- CanvasItem's `update()` -> `queue_redraw()`
- FileDialog's `set_mod()` -> `set_file_mode()` (This one is listed as `set_mode_file_mode` in editor)
- GridMap's `map_to_world()` -> `map_to_local()`
- Image's `get_rect()` -> `get_region()`
- MultiPlayerAPI's `get_network_peer()` -> `get_peer()' (Listed as `has_network_peer()` in editor - which is a duplicate)
- TileMap's `map_to_world` -> `map_to_local`
- Control's `margin` -> `offset` change
- Tween's `tween_all_completed` -> `loop_finished`
- MainLoop's `NOTIFICATION_WM_QUIT_REQUEST1 -> `NOTIFICATION_WM_CLOSE_REQUEST`

**URL to the documentation page:**
[https://docs.godotengine.org/en/stable/tutorials/migrating/upgrading_to_godot_4.html](https://docs.godotengine.org/en/stable/tutorials/migrating/upgrading_to_godot_4.html)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.