godotengine / godotengine/godot-docs

Object.get_meta & has_meta doc mentions is_valid_identifier but deprecated (prefer is_valid_ascii_identifier)

Open
#11,870 0 comments 1 reaction 0 assignees View on GitHub
area:class reference enhancement
Dominant language
reStructuredText
Stars
5.7k
Forks
3.8k
Avg merge
1d 20h
Merged PRs (30d)
25

Description

**Your Godot version:**

4.6

**Issue description:**

The doc for `Object.get_meta` and `has_meta` says:

> Note: A metadata's name must be a valid identifier as per [StringName.is_valid_identifier()](https://docs.godotengine.org/en/4.6/classes/class_stringname.html#class-stringname-method-is-valid-identifier) method.

But clicking on the hyperlinks shows that `is_valid_identifier` is deprecated:

> Deprecated: Use [is_valid_ascii_identifier()](https://docs.godotengine.org/en/4.6/classes/class_stringname.html#class-stringname-method-is-valid-ascii-identifier) instead.

So we might as well just mention `is_valid_ascii_identifier()` from the start.

**URL to the documentation page:**

https://docs.godotengine.org/en/4.6/classes/class_object.html#class-object-method-get-meta
https://docs.godotengine.org/en/4.6/classes/class_object.html#class-object-method-has-meta

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.