godotengine / godotengine/godot-cpp
String::split_ints and split_floats do not use `allow_empty`
- Dominant language
- C++
- Stars
- 2.7k
- Forks
- 809
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 8
Description
`allow_empty` is unused in `String`, making the parameter useless.
The Godot C API however has alternative functions that can be used in case the parameter is specified:
```cpp
godot_array (*godot_string_split)(const godot_string *p_self, const godot_string *p_splitter);
godot_array (*godot_string_split_allow_empty)(const godot_string *p_self, const godot_string *p_splitter);
godot_array (*godot_string_split_floats)(const godot_string *p_self, const godot_string *p_splitter);
godot_array (*godot_string_split_floats_allows_empty)(const godot_string *p_self, const godot_string *p_splitter);
godot_array (*godot_string_split_floats_mk)(const godot_string *p_self, const godot_array *p_splitters);
godot_array (*godot_string_split_floats_mk_allows_empty)(const godot_string *p_self, const godot_array *p_splitters);
godot_array (*godot_string_split_ints)(const godot_string *p_self, const godot_string *p_splitter);
godot_array (*godot_string_split_ints_allows_empty)(const godot_string *p_self, const godot_string *p_splitter);
godot_array (*godot_string_split_ints_mk)(const godot_string *p_self, const godot_array *p_splitters);
godot_array (*godot_string_split_ints_mk_allows_empty)(const godot_string *p_self, const godot_array *p_splitters);
```
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.