godotengine / godotengine/godot-cpp

CRASH_COND should assert, not just log and return

Open
#384 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C++
Stars
2.7k
Forks
809
Avg merge
1d 3h
Merged PRs (30d)
8

Description

When porting code from a module, I noticed the `CRASH_COND` macro in C++ bindings does not actually behave like an assert, but does log something (only with the "FATAL" prefix) and continues execution.

I believe this isn't the intention of this macro, which would otherwise need a variant with value to return... but anyways, I think it should really crash by generating a trap after logging the error, like Godot does.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.