godotengine / godotengine/godot-cpp-template

Windows build missing lib prefix vs. example.gdextension

Open
#38 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
463
Forks
128
PR merge metrics
No merged PRs in 30d

Description

### Godot version

n/a

### godot-cpp version

n/a

### System information

Windows (GitHub build)

### Issue description

There is an inconsistency in the [template build github actions](https://github.com/godotengine/godot-cpp-template/blob/main/.github/actions/build/action.yml) and the [example.gdextension](https://github.com/godotengine/godot-cpp-template/blob/main/demo/bin/example.gdextension).

It seems that the windows build leave out the `lib` prefix from the file name.

The plugin definition has the following reference to a file:
`windows.release.x86_32 = "res://bin/libgdexample.windows.template_release.x86_32.dll"`

but the built file is in reality:
`bin/gdexample.windows.template_release.x86_32.dll`

This can also be verified from this repositorys build artifacts, e.g. [here](https://github.com/godotengine/godot-cpp-template/actions/runs/9365840512/artifacts/1566414348) and looking at the windows binary directory.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.