godaddy / godaddy/terminus

Adding signal type to onSignal function

Open
#294 1 comment 2 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
1.9k
Forks
94
PR merge metrics
No merged PRs in 30d

Description

https://github.com/godaddy/terminus/blob/c1a26fb94d6d03f0b0317c2e9cf36bd13115c3d9/lib/terminus.js#L143
->
```js
await onSignal(signal)
```
For observability I like to track what signal caused the graceful shutdown, could we add the signal as a parameter to onSignal?
I'd be willing to make the PR if that would be helpful

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.