godaddy / godaddy/kubernetes-client

We should bubble up pump errors

Open
#557 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
963
Forks
189
PR merge metrics
No merged PRs in 30d

Description

https://github.com/godaddy/kubernetes-client/blob/master/backends/request/client.js#L179

For some local debugging of the watch example I just did the following which surfaced my error:

```js
pump(stream, jsonStream, (err) => {throw err})
```

Aside: The following issue might be deprecated with the new getObjectStream stuff: https://github.com/godaddy/kubernetes-client/issues/248?

Contributor guide

Open the contributing guide

Research direction

Start in backends/request/client.js around line 179 and inspect how pump errors are handled for the watch example. Check issue #248 and the newer getObjectStream behavior before making changes; done means errors from pump are surfaced rather than silently lost.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
api
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.